Add "type": "module" to package.json #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It ensures that the ESM build of Vite is used instead of the CJS build (deprecated). See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated This is also consistent with the Vite React templates: https://github.com/vitejs/vite/blob/cdc664d4ea98d5373c3ceb2213771f1dfa4bb457/packages/create-vite/template-react-ts/package.json#L5 Because we were using TypeScript to begin with (and therefore the ESM syntax for import/export), no change is required in source files. Note that because ESM ("es") was already the default output format for rollupjs, I don't think there is any difference in the final app (index.html was already using `<script type="module">`). So in essence, this change is really about avoiding the deprecation warning from Vite. .eslintrc.js had to be renamed to .eslintrc.cjs. ESLint currently does not support ESM configuration. Signed-off-by: Antonin Bas <[email protected]>
antoninbas
force-pushed
the
add-type-module-to-package-json
branch
from
166ec95
to
476d274
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It ensures that the ESM build of Vite is used instead of the CJS build (deprecated). See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
This is also consistent with the Vite React templates: https://github.com/vitejs/vite/blob/cdc664d4ea98d5373c3ceb2213771f1dfa4bb457/packages/create-vite/template-react-ts/package.json#L5
Because we were using TypeScript to begin with (and therefore the ESM syntax for import/export), no change is required in source files.
Note that because ESM ("es") was already the default output format for rollupjs, I don't think there is any difference in the final app (index.html was already using
<script type="module">). So in essence, this change is really about avoiding the deprecation warning from Vite.